silvana/implot-rs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use slices instead of Vecs in function parameters

Browse source
This commit is contained in:
Mitsutoshi Aoe 2020-11-10 11:02:00 +09:00 committed by 4bb4
parent 1643032c7a
commit 7e8ea01409
2 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/plot.rs
View file

@ -231,8 +231,8 @@ impl Plot {
/// the form of a tuple `(label_position, label_string)`. The `show_default` setting /// the form of a tuple `(label_position, label_string)`. The `show_default` setting
/// determines whether the default ticks are also shown. /// determines whether the default ticks are also shown.
#[inline] #[inline]
pub fn x_ticks(mut self, ticks: &Vec<f64>, show_default: bool) -> Self { pub fn x_ticks(mut self, ticks: &[f64], show_default: bool) -> Self {
self.x_tick_positions = Some(ticks.clone()); self.x_tick_positions = Some(ticks.into());
self.show_x_default_ticks = show_default; self.show_x_default_ticks = show_default;
self self
} }
@ -244,11 +244,11 @@ impl Plot {
pub fn y_ticks( pub fn y_ticks(
mut self, mut self,
y_axis_choice: YAxisChoice, y_axis_choice: YAxisChoice,
ticks: &Vec<f64>, ticks: &[f64],
show_default: bool, show_default: bool,
) -> Self { ) -> Self {
let axis_index = y_axis_choice as usize; let axis_index = y_axis_choice as usize;
self.y_tick_positions[axis_index] = Some(ticks.clone()); self.y_tick_positions[axis_index] = Some(ticks.into());
self.show_y_default_ticks[axis_index] = show_default; self.show_y_default_ticks[axis_index] = show_default;
self self
} }
@ -259,7 +259,7 @@ impl Plot {
#[inline] #[inline]
pub fn x_ticks_with_labels( pub fn x_ticks_with_labels(
mut self, mut self,
tick_labels: &Vec<(f64, String)>, tick_labels: &[(f64, String)],
show_default: bool, show_default: bool,
) -> Self { ) -> Self {
self.x_tick_positions = Some(tick_labels.iter().map(|x| x.0).collect()); self.x_tick_positions = Some(tick_labels.iter().map(|x| x.0).collect());
@ -275,7 +275,7 @@ impl Plot {
pub fn y_ticks_with_labels( pub fn y_ticks_with_labels(
mut self, mut self,
y_axis_choice: YAxisChoice, y_axis_choice: YAxisChoice,
tick_labels: &Vec<(f64, String)>, tick_labels: &[(f64, String)],
show_default: bool, show_default: bool,
) -> Self { ) -> Self {
let axis_index = y_axis_choice as usize; let axis_index = y_axis_choice as usize;

8
src/plot_elements.rs
View file

@ -22,7 +22,7 @@ impl PlotLine {
} }
/// Plot a line. Use this in closures passed to [`Plot::build()`](struct.Plot.html#method.build) /// Plot a line. Use this in closures passed to [`Plot::build()`](struct.Plot.html#method.build)
pub fn plot(&self, x: &Vec<f64>, y: &Vec<f64>) { pub fn plot(&self, x: &[f64], y: &[f64]) {
// If there is no data to plot, we stop here // If there is no data to plot, we stop here
if x.len().min(y.len()) == 0 { if x.len().min(y.len()) == 0 {
return; return;
@ -56,7 +56,7 @@ impl PlotStairs {
/// Plot a stairs style line. Use this in closures passed to /// Plot a stairs style line. Use this in closures passed to
/// [`Plot::build()`](struct.Plot.html#method.build) /// [`Plot::build()`](struct.Plot.html#method.build)
pub fn plot(&self, x: &Vec<f64>, y: &Vec<f64>) { pub fn plot(&self, x: &[f64], y: &[f64]) {
// If there is no data to plot, we stop here // If there is no data to plot, we stop here
if x.len().min(y.len()) == 0 { if x.len().min(y.len()) == 0 {
return; return;
@ -90,7 +90,7 @@ impl PlotScatter {
/// Draw a previously-created scatter plot. Use this in closures passed to /// Draw a previously-created scatter plot. Use this in closures passed to
/// [`Plot::build()`](struct.Plot.html#method.build) /// [`Plot::build()`](struct.Plot.html#method.build)
pub fn plot(&self, x: &Vec<f64>, y: &Vec<f64>) { pub fn plot(&self, x: &[f64], y: &[f64]) {
// If there is no data to plot, we stop here // If there is no data to plot, we stop here
if x.len().min(y.len()) == 0 { if x.len().min(y.len()) == 0 {
return; return;
@ -147,7 +147,7 @@ impl PlotBars {
/// [`Plot::build()`](struct.Plot.html#method.build). The `axis_positions` /// [`Plot::build()`](struct.Plot.html#method.build). The `axis_positions`
/// specify where on the corersponding axis (X for vertical mode, Y for horizontal mode) the /// specify where on the corersponding axis (X for vertical mode, Y for horizontal mode) the
/// bar is drawn, and the `bar_values` specify what values the bars have. /// bar is drawn, and the `bar_values` specify what values the bars have.
pub fn plot(&self, axis_positions: &Vec<f64>, bar_values: &Vec<f64>) { pub fn plot(&self, axis_positions: &[f64], bar_values: &[f64]) {
let number_of_points = axis_positions.len().min(bar_values.len()); let number_of_points = axis_positions.len().min(bar_values.len());
// If there is no data to plot, we stop here // If there is no data to plot, we stop here
if number_of_points == 0 { if number_of_points == 0 {